ENH: adding support for Py3.6+ memory tracing for khash-maps #38048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…milar to the way numpy does
…is PyObjectHashMap used as can be seen on the basis of expected result for 32bit build (and not Float64)
realead
force-pushed
the
tracemalloc_for_khash
branch
from
d3de0d8
to
3f9fc46
Compare
jreback
added
Benchmark
|
thanks @realead very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffTracemalloc is a standard tool for tracing of memory consumption in Python. Until now khash-maps were invisible for this tool.
This PR follows more or less numpy's approach (see numpy/numpy@03534ec) for adding tracemalloc-support.
This PR fixes also silly mistakes from #37920 (see 3291ed1) and the somewhat imprecise implementation of
sizeofforXXXHashTable-classes.