Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: pytables in py39 #38041

Merged
merged 4 commits into from
Nov 25, 2020
Merged

BUG: pytables in py39 #38041

merged 4 commits into from
Nov 25, 2020

Conversation

jbrockmendel
Copy link
Member

There are failures I'm getting locally since homebrew bumped up to py39. I'm not seeing them on the CI, but they did appear around the same time as these different unexplained pytables failures started showing up.

@@ -4462,7 +4462,7 @@ def test_categorical(self, setup_path):

# Appending must have the same categories
df3 = df.copy()
df3["s"].cat.remove_unused_categories(inplace=True)
df3["s"] = df3["s"].cat.remove_unused_categories()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated, just getting rid of a FutureWarning

Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jreback
Copy link
Contributor

jreback commented Nov 25, 2020

can you add pytables to the 3.9 build (I guess its built now?) https://github.com/pandas-dev/pandas/blob/master/ci/deps/azure-39.yaml

@jreback jreback added the IO HDF5 read_hdf, HDFStore label Nov 25, 2020
@jbrockmendel
Copy link
Member Author

can you add pytables to the 3.9 build (I guess its built now?) https://github.com/pandas-dev/pandas/blob/master/ci/deps/azure-39.yaml

it doesnt have a wheel, so i think the build would take too long

@jreback
Copy link
Contributor

jreback commented Nov 25, 2020

it needs to be installed via conda forge

i am sure it's there

@jbrockmendel
Copy link
Member Author

it needs to be installed via conda forge

sounds good, just pushed

@jreback
Copy link
Contributor

jreback commented Nov 25, 2020

i think that worked, great. There is an issue to add more deps to this build let me bump it.

@jreback jreback added this to the 1.2 milestone Nov 25, 2020
@jreback
Copy link
Contributor

jreback commented Nov 25, 2020

I guess should put a release note?

@jbrockmendel
Copy link
Member Author

I guess should put a release note?

for 1.1.x?

@jreback
Copy link
Contributor

jreback commented Nov 25, 2020

I guess should put a release note?

for 1.1.x?

hmm yeah

while you are at it, can you add scipy and pyarrow==1.0 (though not sure they support 3.9 with that version)

@jreback jreback modified the milestones: 1.2, 1.1.5 Nov 25, 2020
@jbrockmendel
Copy link
Member Author

scipy/pyarrow added and green

@jreback jreback merged commit 336cc6c into pandas-dev:master Nov 25, 2020
@lumberbot-app

This comment has been minimized.

simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Nov 25, 2020
* BUG: pytables in py39

* add pytables to py39 ci

* whatsnew 1.1.5

* scipy and pyarrow to py39 build
simonjayhawkins added a commit that referenced this pull request Nov 25, 2020
Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
@jbrockmendel jbrockmendel deleted the bug-slobj branch November 25, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HDF5 read_hdf, HDFStore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants