REGR: fix inplace operations for EAs with non-EA arg #37986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
added
ExtensionArray
|
@arw2019 can you add a release note to the regression section of doc\source\whatsnew\v1.1.5.rst |
| "ser1, ser2, expected_add, expected_sub, expected_mul", | ||
| ( | ||
| [ | ||
| Series([1], dtype="Int64"), |
There was a problem hiding this comment.
could you do the Series construction inside the test and just have the dtypes in the parameters?
jreback
requested changes
Nov 21, 2020
| ), | ||
| ) | ||
| def test_series_inplace_ops(dtype1, dtype2, dtype_expected, dtype_mul): | ||
|
|
There was a problem hiding this comment.
GH ref to either this PR or original issue
doc/source/whatsnew/v1.1.5.rst
Outdated
| @@ -17,7 +17,7 @@ Fixed regressions | |||
| - Regression in addition of a timedelta-like scalar to a :class:`DatetimeIndex` raising incorrectly (:issue:`37295`) | |||
| - Fixed regression in :meth:`Series.groupby` raising when the :class:`Index` of the :class:`Series` had a tuple as its name (:issue:`37755`) | |||
| - Fixed regression in :meth:`DataFrame.loc` and :meth:`Series.loc` for ``__setitem__`` when one-dimensional tuple was given to select from :class:`MultiIndex` (:issue:`37711`) | |||
| - | |||
| - Fixed regression in inplace operations on :class:``ExtensionArray`` with NumPy array argument (:issue:`37910`) | |||
There was a problem hiding this comment.
is it on EA or on Series with EA dtype?
There was a problem hiding this comment.
it's Series with EA dtype
There was a problem hiding this comment.
yeah let's reword this, its an inplace operation on a Series with an EA dtype with a numpyt dtyped operand
jreback
requested changes
Nov 23, 2020
doc/source/whatsnew/v1.1.5.rst
Outdated
| @@ -17,7 +17,7 @@ Fixed regressions | |||
| - Regression in addition of a timedelta-like scalar to a :class:`DatetimeIndex` raising incorrectly (:issue:`37295`) | |||
| - Fixed regression in :meth:`Series.groupby` raising when the :class:`Index` of the :class:`Series` had a tuple as its name (:issue:`37755`) | |||
| - Fixed regression in :meth:`DataFrame.loc` and :meth:`Series.loc` for ``__setitem__`` when one-dimensional tuple was given to select from :class:`MultiIndex` (:issue:`37711`) | |||
| - | |||
| - Fixed regression in inplace operations on :class:``ExtensionArray`` with NumPy array argument (:issue:`37910`) | |||
There was a problem hiding this comment.
yeah let's reword this, its an inplace operation on a Series with an EA dtype with a numpyt dtyped operand
jreback
approved these changes
Nov 24, 2020
|
thanks @arw2019 |
|
@meeseeksdev backport 1.1.x |
This comment has been minimized.
This comment has been minimized.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Nov 24, 2020
…tions for EAs with non-EA arg
simonjayhawkins
added a commit
that referenced
this pull request
Nov 25, 2020
…EAs with non-EA arg (#38035) Co-authored-by: Andrew Wieteska <48889395+arw2019@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff