BUG: loc.setitem corner case #37931
Merged
BUG: loc.setitem corner case #37931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
the
Indexing
phofl
reviewed
Nov 18, 2020
| if len(value) == 1 and not is_integer(info_axis): | ||
| # This is a case like df.iloc[:3, [1]] = [0] | ||
| # where we treat as df.iloc[:3, 1] = 0 | ||
| return self._setitem_with_indexer((pi, info_axis[0]), value[0]) |
There was a problem hiding this comment.
Is there a reason for not using _setitem_single_column? Seems to work when trying out locally. LGTM otherwise
There was a problem hiding this comment.
either way works. this seemed like a more obvious "we are reducing this to a simpler case" representation
This was referenced Nov 22, 2020
jreback
reviewed
Nov 26, 2020
| @@ -210,6 +210,11 @@ def test_multiindex_assignment(self): | |||
| with pytest.raises(ValueError, match=msg): | |||
| df.loc[4, "c"] = [0] | |||
|
|
|||
| # But with a length-1 listlike column indexer this works | |||
| df.loc[4, ["c"]] = [0] | |||
There was a problem hiding this comment.
what happens with this case now?
There was a problem hiding this comment.
behaves like df.loc[4, "c"] = 0, just edited the comment to make that clear
|
rebased+green |
jreback
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffcc @phofl if you've got any thoughts on how to handle this case