BUG: MultiIndex.drop does not raise if labels are partially found #37830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Nov 14, 2020
pandas/core/indexes/multi.py
Outdated
| @@ -2157,9 +2157,10 @@ def _drop_from_level(self, codes, level, errors="raise"): | |||
| index = self.levels[i] | |||
| values = index.get_indexer(codes) | |||
|
|
|||
| not_found = np.array(codes)[np.array(values) == -1].tolist() | |||
There was a problem hiding this comment.
That won't work after #37794 is merged. Could you rebase afterwards? Please check for len(not_found)
There was a problem hiding this comment.
not necessary, I will alter this after phofl's PR merged.
jreback
requested changes
Nov 15, 2020
|
cc @jreback |
jreback
requested changes
Nov 25, 2020
There was a problem hiding this comment.
looks good, very minor comment, can you merge master and ping on green.
cc @phofl @jbrockmendel if comments
phofl
reviewed
Nov 26, 2020
| @@ -147,3 +147,22 @@ def test_drop_with_nan_in_index(nulls_fixture): | |||
| msg = r"labels \[Timestamp\('2001-01-01 00:00:00'\)\] not found in level" | |||
| with pytest.raises(KeyError, match=msg): | |||
| mi.drop(pd.Timestamp("2001"), level="date") | |||
|
|
|||
|
|
|||
| def test_single_level_drop(): | |||
There was a problem hiding this comment.
Could you rename to something like test_single_level_drop_partially_missing_elements?
There was a problem hiding this comment.
@GYHHAHA can you do this one, ping on green.
jreback
approved these changes
Nov 26, 2020
|
thanks @GYHHAHA very nice, keep em coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff