Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add examples to insert and update generally #37690

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

erictleung
Copy link
Contributor

This commit mainly adds examples on usage. This commit also fills in
information suggested by validate_docstrings.py script.

Ran

python scripts/validate_docstrings.py pandas.DataFrame.insert

to check docs and added in suggested information (e.g., See Also section).

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erictleung for the PR!

Small comments, LGTM otherwise

pandas/core/frame.py Outdated Show resolved Hide resolved
pandas/core/frame.py Outdated Show resolved Hide resolved
pandas/core/frame.py Outdated Show resolved Hide resolved
@erictleung
Copy link
Contributor Author

@arw2019 changes made. Thanks for the feedback!

@mroeschke
Copy link
Member

Sorry this PR has been unaddressed for a while. LGTM but could you merge master one more time?

This commit mainly adds examples on usage. This commit also fills in
information suggested by `validate_docstrings.py` script.
@erictleung
Copy link
Contributor Author

erictleung commented Dec 7, 2020

@mroeschke thanks for taking a look at this! I rebased my branch onto the most recent commits on master. That should resolve any issues merging. Let me know if there are any issues going forward in merging.

@mroeschke mroeschke added the Docs label Dec 7, 2020
@mroeschke mroeschke added this to the 1.3 milestone Dec 7, 2020
@mroeschke mroeschke merged commit d3e970b into pandas-dev:master Dec 8, 2020
@mroeschke
Copy link
Member

Thanks @erictleung

@erictleung erictleung deleted the add-insert-examples branch December 8, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants