BUG: Fix .hist and .plot.hist when passing existing figure (#37278) #37467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
reviewed
Oct 29, 2020
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -476,6 +476,7 @@ Plotting | |||
|
|
|||
| - Bug in :meth:`DataFrame.plot` was rotating xticklabels when ``subplots=True``, even if the x-axis wasn't an irregular time series (:issue:`29460`) | |||
| - Bug in :meth:`DataFrame.plot` where a marker letter in the ``style`` keyword sometimes causes a ``ValueError`` (:issue:`21003`) | |||
| - Bug in :meth:`DataFrame.hist`, :meth:`DataFrame.plot.hist` and :meth:`Series.plot.hist` when passing an existing figure (:issue:`37278`) | |||
There was a problem hiding this comment.
this should go in enhancements I think. Something like
:meth:`DataFrame.hist`, :meth:`DataFrame.plot.hist` can now be called with an existing matplotlib figure object via added ``figure`` argument
Possibly add an example (not 100% that's needed though)
| @@ -152,6 +152,13 @@ def test_hist_with_legend_raises(self, by): | |||
| with pytest.raises(ValueError, match="Cannot use both legend and label"): | |||
| s.hist(legend=True, by=by, label="c") | |||
|
|
|||
| def test_hist_with_passed_figure(self): | |||
There was a problem hiding this comment.
I'd call this test_hist_with_figure_argument
| @@ -395,6 +402,13 @@ def test_hist_with_legend_raises(self, by, column): | |||
| with pytest.raises(ValueError, match="Cannot use both legend and label"): | |||
| df.hist(legend=True, by=by, column=column, label="d") | |||
|
|
|||
| def test_hist_with_passed_figure(self): | |||
There was a problem hiding this comment.
I'd call this test_hist_with_figure_argument
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
1 task
|
@charlesdong1991 can you take a look |
|
closing as stale, if you want to continue working, please ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff