Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/API: tighter checks on DTI/TDI.equals #36962

Merged
merged 4 commits into from
Oct 8, 2020

Conversation

jbrockmendel
Copy link
Member

Also fixes TimedeltaIndex(Categorical(tdi)) (which DatetimeIndex already gets right)

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, ping on green.

pandas/core/indexes/datetimelike.py Show resolved Hide resolved
@jreback jreback added the Numeric Operations Arithmetic, Comparison, and Logical operations label Oct 8, 2020
@jreback jreback added this to the 1.2 milestone Oct 8, 2020
@jreback
Copy link
Contributor

jreback commented Oct 8, 2020

ci / checks are failing

@jbrockmendel
Copy link
Member Author

mypy complaints fixed; unrelated windows+plotting failure

@jreback jreback merged commit a6db928 into pandas-dev:master Oct 8, 2020
@jbrockmendel jbrockmendel deleted the poc-equals branch October 8, 2020 21:27
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants