Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: Ignore remaining mypy errors for pandas\tests\* #36724

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

simonjayhawkins
Copy link
Member

These are the only 3 errors outstanding in pandas\tests* that are stopping us closing #28926

pandas\conftest.py:301: error: List item 0 has incompatible type "Type[Index]"; expected "Type[PandasObject]"  [list-item]
pandas\tests\window\conftest.py:79: error: List item 0 has incompatible type "ParameterSet"; expected "Sequence[Collection[object]]"  [list-item]
pandas\tests\window\conftest.py:330: error: List item 15 has incompatible type "ParameterSet"; expected "Sequence[Collection[object]]"  [list-item]

these appear to be from a mypy inference issue. It maybe best to # type: ignore[list-item] just these lines and remove the ignore_errors=True from setup.cfg that applies to the whole file for all error codes.

if the mypy error is resolved in a future release, the warn_unused_ignores = True in setup.cfg means that we will be alerted and the ignores can be removed.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Sep 29, 2020
@WillAyd WillAyd added this to the 1.2 milestone Sep 29, 2020
@WillAyd WillAyd merged commit 0ecff23 into pandas-dev:master Sep 29, 2020
@WillAyd
Copy link
Member

WillAyd commented Sep 29, 2020

Thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the conftest-ignores branch September 30, 2020 11:06
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mypy errors for pandas\tests\*
3 participants