CI: Revert 31323 for deprecation warning from Jedi #35845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesdong1991
changed the title
|
emm, seems with the latest version of ipython (7.17.0) and jedi (0.17.2), the deprecation warning is still there. I converted this PR to WIP, and will ask in ipython issue again about this. |
|
Is this still active? |
|
emm, it is blocked by an ipython issue. my previous issue was closed ipython/ipython#12102 however, it wasn't being solved in the later version of ipython there is a new issue ipython/ipython#12597 now tracking this warning issue, not sure if the fix will be included a newer version. |
|
what is the status here? |
|
@charlesdong1991 can you merge master and ping on green |
|
we have a new jedi issue, but this one is moot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipython/ipython#12102 has been solved, and the new release came out a couple weeks ago, so revert should be fine according to ipython/ipython#12102 (comment)