-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: ints_to_pydatetime #35113
Merged
jreback
merged 7 commits into
pandas-dev:master
from
jbrockmendel:ref-ints_to_pydatetime-3
Jul 6, 2020
Merged
PERF: ints_to_pydatetime #35113
jreback
merged 7 commits into
pandas-dev:master
from
jbrockmendel:ref-ints_to_pydatetime-3
Jul 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-ints_to_pydatetime-3
…f-ints_to_pydatetime-3
…f-ints_to_pydatetime-3
gfyoung
added
Performance
Memory or execution speed performance
Datetime
Datetime data dtype
labels
Jul 3, 2020
WillAyd
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
very nice, cleaning up some nasty code + perf! |
i merged everything above (i think) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors ints_to_pydatetime to use a much more concise pattern (similar to #35077 but without the helper function refactored out) that I intend to move all of the ~7 functions using get_dst_info to use. In the process, we are slower on very small arrays and faster on bigger arrays, which I think is a good trade: