Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: remove libreduction.Reducer #35001

Merged
merged 4 commits into from
Jun 26, 2020
Merged

CLN: remove libreduction.Reducer #35001

merged 4 commits into from
Jun 26, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jreback jreback added Performance Memory or execution speed performance Clean labels Jun 26, 2020
@jreback jreback added this to the 1.1 milestone Jun 26, 2020
@jreback
Copy link
Contributor

jreback commented Jun 26, 2020

nice, merge master (as previously cleared a lint issue)

@WillAyd
Copy link
Member

WillAyd commented Jun 26, 2020

Any performance diff in doing this?

@jbrockmendel
Copy link
Member Author

Any performance diff in doing this?

No. We removed the only non-test usages of this in #34913 and #34909, which were both measured as perf-neutral.

@jreback jreback merged commit b8d4892 into pandas-dev:master Jun 26, 2020
@jbrockmendel jbrockmendel deleted the cln-reducer branch June 26, 2020 20:31
fangchenli pushed a commit to fangchenli/pandas that referenced this pull request Jun 27, 2020
@jbrockmendel @fangchenli
CLN: remove libreduction.Reducer (pandas-dev#35001)
e57f967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean Performance Memory or execution speed performance
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @WillAyd