Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: accept a dictionary in plot colors #31071

Merged
merged 4 commits into from
Jan 26, 2020

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jan 16, 2020

This is a resurrection of #28659. Have kept the original commit history, just rebased and added docstrings.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits on documentation

pandas/plotting/_core.py Outdated Show resolved Hide resolved
pandas/plotting/_core.py Outdated Show resolved Hide resolved
@WillAyd WillAyd added the Visualization plotting label Jan 16, 2020
doc/source/whatsnew/v1.0.0.rst Outdated Show resolved Hide resolved
@WillAyd WillAyd changed the title Issue 8193 accept a dictionary in plot colors Jan 16, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandas/plotting/_core.py Outdated Show resolved Hide resolved
pandas/plotting/_core.py Outdated Show resolved Hide resolved
@MarcoGorelli MarcoGorelli force-pushed the issue-8193 branch 2 times, most recently from 73ecd09 to 7a45f5b Compare January 19, 2020 09:46
@MarcoGorelli MarcoGorelli changed the title accept a dictionary in plot colors (wip) accept a dictionary in plot colors Jan 19, 2020
@MarcoGorelli MarcoGorelli changed the title (wip) accept a dictionary in plot colors accept a dictionary in plot colors Jan 19, 2020
@MarcoGorelli
Copy link
Member Author

@jreback have done some docstring-sharing, here are some screenshots:

image
image
image
image
image
image

@jreback jreback added this to the 1.1 milestone Jan 24, 2020
@jreback
Copy link
Contributor

jreback commented Jan 24, 2020

great lgtm. if @datapythonista or @simonjayhawkins have any comments on the doc-strings otherwise merge away.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, nice feature. Thanks!

@MarcoGorelli MarcoGorelli changed the title accept a dictionary in plot colors ENH: accept a dictionary in plot colors Jan 24, 2020
@jreback jreback merged commit 15257ea into pandas-dev:master Jan 26, 2020
@jreback
Copy link
Contributor

jreback commented Jan 26, 2020

thanks @MarcoGorelli

keechongtan added a commit to keechongtan/pandas that referenced this pull request Jan 27, 2020
…ndexing-1row-df

* upstream/master: (194 commits)
  DOC Remove Python 2 specific comments from documentation (pandas-dev#31198)
  Follow up PR: pandas-dev#28097 Simplify branch statement (pandas-dev#29243)
  BUG: DatetimeIndex.snap incorrectly setting freq (pandas-dev#31188)
  Move DataFrame.info() to live with similar functions (pandas-dev#31317)
  ENH: accept a dictionary in plot colors (pandas-dev#31071)
  PERF: add shortcut to Timestamp constructor (pandas-dev#30676)
  CLN/MAINT: Clean and annotate stata reader and writers (pandas-dev#31072)
  REF: define _get_slice_axis in correct classes (pandas-dev#31304)
  BUG: DataFrame.floordiv(ser, axis=0) not matching column-wise bheavior (pandas-dev#31271)
  PERF: optimize is_scalar, is_iterator (pandas-dev#31294)
  BUG: Series rolling count ignores min_periods (pandas-dev#30923)
  xfail sparse warning; closes pandas-dev#31310 (pandas-dev#31311)
  REF: DatetimeIndex.get_value wrap DTI.get_loc (pandas-dev#31314)
  CLN: internals.managers (pandas-dev#31316)
  PERF: avoid copies if possible in fill_binop (pandas-dev#31300)
  Add test for multiindex json (pandas-dev#31307)
  BUG: passing TDA and wrong freq to TimedeltaIndex (pandas-dev#31268)
  BUG: inconsistency between PeriodIndex.get_value vs get_loc (pandas-dev#31172)
  CLN: remove _set_subtyp (pandas-dev#31301)
  CI: Updated version of macos image (pandas-dev#31292)
  ...
@MarcoGorelli MarcoGorelli deleted the issue-8193 branch February 1, 2020 18:18
@MarcoGorelli
Copy link
Member Author

Happy to help, thanks @Leostayner for having started this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing a dictionary of columns names and colors
5 participants