IntegerArray.to_numpy #30792
Merged
IntegerArray.to_numpy #30792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
force-pushed
the
IntegerArray-to_numpy
branch
from
b87b91c
to
5156db0
Compare
TomAugspurger
added
API - Consistency
TomAugspurger
added
the
Missing-data
TomAugspurger
commented
Jan 7, 2020
WillAyd
approved these changes
Jan 8, 2020
|
Thanks @TomAugspurger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements IntegerArray.to_numpy with similar semantics to BooleanArray.to_numpy. The implementation is now identical between BooleanArray & IntegerArray. #30789 will merge them.
.to_numpy(dtype=float/bool/int)will raise if there are missing values.astype(float)will convert NA to NaN.I've made a slight change from the BooleanArray implementation on master, which I'll annotate inline.
Closes #30038