Fix flakey base setitem test #30660
Merged
Fix flakey base setitem test #30660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Jan 3, 2020
| @@ -189,11 +189,9 @@ def test_setitem_scalar_key_sequence_raise(self, data): | |||
|
|
|||
| def test_setitem_preserves_views(self, data): | |||
| # GH#28150 setitem shouldn't swap the underlying data | |||
| assert data[-1] != data[0] # otherwise test would not be meaningful | |||
There was a problem hiding this comment.
if we start with data[0] == data[1] then the assertions below aren't testing anything useful. some of the data fixtures check for a condition similar to this one
There was a problem hiding this comment.
We require that they be unequal:
pandas/pandas/tests/extension/conftest.py
Line 19 in 45d8d77
|
Thanks @TomAugspurger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test makes a potentially incorrect assertion about the data provided to the test. We already require that
data[0] != data[1], so it can be used instead.This failed in https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=24731&view=logs&j=a67b4c4c-cd2e-5e3c-a361-de73ac9c05f9&t=33d2fdd0-c376-5f94-e6d3-957bdd23a3b8.