REF: Delegate more methods for DTI/TDI/PI #30607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 2, 2020
| @@ -445,7 +445,7 @@ def _formatter(self, boxed=False): | |||
|
|
|||
| return _get_format_timedelta64(self, box=True) | |||
|
|
|||
| def _format_native_types(self, na_rep="NaT", date_format=None): | |||
| def _format_native_types(self, na_rep="NaT", date_format=None, **kwargs): | |||
There was a problem hiding this comment.
do we actually use these kwargs (i know they are on the method you are removing)?
There was a problem hiding this comment.
yes, without this we get a test failure bc float_format is passed
There was a problem hiding this comment.
ahh i c, as these are fairly generic, ok then.
jreback
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.