CLN: BlockManager.apply #29825
Merged
CLN: BlockManager.apply #29825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
requested changes
Nov 24, 2019
pandas/core/internals/managers.py
Outdated
| @@ -772,13 +756,15 @@ def copy(self, deep=True): | |||
| # this preserves the notion of view copying of axes | |||
| if deep: | |||
| if deep == "all": | |||
| copy = lambda ax: ax.copy(deep=True) | |||
| copy_func = lambda ax: ax.copy(deep=True) | |||
There was a problem hiding this comment.
Could you make this a named function? Same below.
topper-123
added
Internals
jreback
approved these changes
Nov 25, 2019
5 tasks
|
rebased+green |
jreback
reviewed
Nov 27, 2019
| @@ -5664,7 +5664,7 @@ def _to_dict_of_blocks(self, copy=True): | |||
| for k, v, in self._data.to_dict(copy=copy).items() | |||
| } | |||
|
|
|||
| def astype(self, dtype, copy=True, errors="raise"): | |||
| def astype(self, dtype, copy: bool_t = True, errors: str = "raise"): | |||
There was a problem hiding this comment.
did you mean to use bool_t here?
There was a problem hiding this comment.
Yes. We can't use bool here because NDFrame defines bool, see note on L142
jreback
approved these changes
Dec 1, 2019
|
thanks @jbrockmendel |
keechongtan
added a commit
to keechongtan/pandas
that referenced
this pull request
Dec 2, 2019
…ndexing-1row-df * upstream/master: (49 commits) repr() (pandas-dev#29959) DOC : Typo fix in userguide/Styling (pandas-dev#29956) CLN: small things in pytables (pandas-dev#29958) API/DEPR: Change default skipna behaviour + deprecate numeric_only in Categorical.min and max (pandas-dev#27929) DEPR: DTI/TDI/PI constructor arguments (pandas-dev#29930) CLN: fix pytables passing too many kwargs (pandas-dev#29951) Typing (pandas-dev#29947) repr() (pandas-dev#29948) repr() (pandas-dev#29950) Added space at the end of the sentence (pandas-dev#29949) ENH: add NA scalar for missing value indicator, use in StringArray. (pandas-dev#29597) CLN: BlockManager.apply (pandas-dev#29825) TST: add test for rolling max/min/mean with DatetimeIndex over different frequencies (pandas-dev#29932) CLN: explicit signature for to_hdf (pandas-dev#29939) CLN: make kwargs explicit for pytables read_ methods (pandas-dev#29935) Convert core/indexes/base.py to f-strings (pandas-dev#29903) DEPR: dropna multiple axes, fillna int for td64, from_codes with floats, Series.nonzero (pandas-dev#29875) CLN: make kwargs explicit in pytables constructors (pandas-dev#29936) DEPR: tz_convert in the Timestamp constructor raises (pandas-dev#29929) STY: F-strings and repr (pandas-dev#29938) ...
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on arithmetic, we're going to be sending some functions through BlockManager.apply. This is just cleaning that up a bit as a preliminary.