Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: loc with listlikes with missing elements #29802

Merged
merged 7 commits into from
Nov 29, 2019

Conversation

jbrockmendel
Copy link
Member

I'm less confident in this one than in others. Some of the affected tests seem to involve non-missing labels in duplicate-containing indexes. Did I conflate multiple issues/deprecations?

@gfyoung gfyoung added Clean Deprecate Functionality to remove in pandas labels Nov 24, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, couple of comments

pandas/io/formats/excel.py Outdated Show resolved Hide resolved
result = df2.loc[idx]
tm.assert_frame_equal(result, expected, check_index_type=False)
with pytest.raises(KeyError, match="with any missing labels"):
# TODO: should non-uniquness play a part in the error message?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, yes I would agree here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, ill see what i can do here.

BTW in #6581 are we removing things in the 0.25.0 section or only the earlier ones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm the non-uniqueness doesn't seem to play any part in us getting here, so im now leaning towards not having a special message

@jbrockmendel
Copy link
Member Author

rebased+green

@jreback jreback added this to the 1.0 milestone Nov 27, 2019
@jreback jreback merged commit cb05112 into pandas-dev:master Nov 29, 2019
@jreback
Copy link
Contributor

jreback commented Nov 29, 2019

thanks @jbrockmendel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants