Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Added annotations. #29506

Merged
merged 1 commit into from
Nov 9, 2019
Merged

CLN: Added annotations. #29506

merged 1 commit into from
Nov 9, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Nov 9, 2019

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@alimcmaster1 alimcmaster1 added the Typing type annotations, mypy/pyright type checking label Nov 9, 2019
@ShaharNaveh
Copy link
Member Author

ShaharNaveh commented Nov 9, 2019

I'm really confused about how it failed.

@alimcmaster1
Copy link
Member

Don't think the test failures are related to this change - I see the same on the latest PR that was merged -
https://github.com/pandas-dev/pandas/runs/295247988

@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Nov 9, 2019
@ShaharNaveh
Copy link
Member Author

I'm now even more confused, about the fact that it passed.

@alimcmaster1
Copy link
Member

I'm now even more confused, about the fact that it passed.

The test is unreliable ive raised an issue here: #29514

@jbrockmendel
Copy link
Member

Thanks @MomIsBestFriend

@jbrockmendel jbrockmendel merged commit 7b9af02 into pandas-dev:master Nov 9, 2019
@ShaharNaveh ShaharNaveh deleted the Compact-typing branch November 11, 2019 08:49
keechongtan added a commit to keechongtan/pandas that referenced this pull request Nov 11, 2019
…ndexing-1row-df

* upstream/master: (109 commits)
  stronger typing in libreduction (pandas-dev#29502)
  API: rename labels to codes (pandas-dev#29509)
  CLN: remove unnecessary type checks (pandas-dev#29517)
  implement _BaseGrouper (pandas-dev#29520)
  CLN: F-string formatting in pandas/_libs/*.pyx (pandas-dev#29527)
  Fixed more SS03 errors (pandas-dev#29540)
  consolidate dim checks (pandas-dev#29536)
  REF: separate out _get_cython_func_and_vals (pandas-dev#29537)
  remove unnecessary exception (pandas-dev#29538)
  TST:Add test to check single category col returns series with single row slice (pandas-dev#29521)
  Make color validation more forgiving (pandas-dev#29122)
  DOC: update bottleneck repo and documentation urls (pandas-dev#29516)
  TST: add test for df construction from dict with tuples (pandas-dev#29497)
  add test for pd.melt dtypes preservation (pandas-dev#29510)
  updated DataFrame.equals docstring (pandas-dev#29496)
  Resolved merge conflicts (pandas-dev#29506)
  DOC: Improved pandas/compact/__init__.py (pandas-dev#29507)
  DOC: Update performance comparison section of io docs (pandas-dev#28890)
  TST: add test for df.where() with category dtype (pandas-dev#29454)
  DOC: Fix docs on merging categoricals. (pandas-dev#28185)
  ...
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants