Fix mypy errors tests.dtypes.test_common #29110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses a subtask of issue pandas-dev#28926
|
@AbhijeetKrishnan can you rebase |
simonjayhawkins
changed the title
simonjayhawkins
requested changes
Oct 21, 2019
There was a problem hiding this comment.
Thanks @AbhijeetKrishnan for the PR.
we generally want to avoid cast, see https://dev.pandas.io/docs/development/contributing.html#style-guidelines
|
@simonjayhawkins Thanks for the review. I will try to see how the code might be refactored to appease mypy. I plan on submitting another PR if I fix it, so this PR can be closed. |
no need. make updates on same branch and push to keep history. |
|
@AbhijeetKrishnan can you rebase |
|
@AbhijeetKrishnan can you rebase, this looks about ready |
|
Looks like this has now been addressed in #29179 thanks all the same @AbhijeetKrishnan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #28926
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff