Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: tests/extension/json/test_json.py typefix #28994

Closed
wants to merge 19 commits into from
Closed

CLN: tests/extension/json/test_json.py typefix #28994

wants to merge 19 commits into from

Commits on Oct 12, 2019

  1. CLN: fix mypy errors in pandas/tests/extension/test_numpy.py pandas-d… 

    …ev#28926
    @lukasbk
    lukasbk committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    a19c844 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2019

  1. Applied suggestions, PR also fixes errors in test_sparse.py

    @lukasbk
    lukasbk committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    28b7120 View commit details
    Browse the repository at this point in the history

  2. Adjusted imports

    @lukasbk
    lukasbk committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    008fe48 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. CLN: added type hint for mypy to test_coercion.py

    @lukasbk
    lukasbk committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    217adc8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into test_coercion_typ… 

    …efix
    @lukasbk
    lukasbk committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    ea903c9 View commit details
    Browse the repository at this point in the history

  3. Fixed mypy error in test_json.py 

    The error is due to the fact that the builtins.staticmethod type defined
 in extension.base.base.BaseExtensionTests does not match the function
type in extension.json.test_json.BaseJSON. I don't see a possibility for
a type hint fix without changing the structure of the code. One way
would be to replace the call of staticmethod by function definitions
that call the corresponding methods.
Here I propose an easier suppression of the error using type: Any.
What do you think?
    @lukasbk
    lukasbk committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    8e8daed View commit details
    Browse the repository at this point in the history

  4. reformatting

    @lukasbk
    lukasbk committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    524ce17 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Revert "CLN: added type hint for mypy to test_coercion.py" 

    This reverts commit 217adc8.
    @lukasbk
    lukasbk committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    c642ade View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into test_json_typefix

    @lukasbk
    lukasbk committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    b70688f View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2019

  1. Matching arguments of assert_..._equal methods

    @lukasbk
    lukasbk committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    acf78f9 View commit details
    Browse the repository at this point in the history

  2. Reformatting

    @lukasbk
    lukasbk committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    6636d8e View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Merge branch 'master' into test_json_typefix

    @simonjayhawkins
    simonjayhawkins authored Oct 21, 2019
    Configuration menu
    Copy the full SHA
    88ef8dd View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Removed returns

    @lukasbk
    lukasbk committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    cfd604c View commit details
    Browse the repository at this point in the history

  2. fix setup.cfg merge conflict

    @lukasbk
    lukasbk committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    d1928e9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'test_json_typefix' of github.com:lukasbk/pandas into te… 

    …st_json_typefix
    @lukasbk
    lukasbk committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    1549313 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. Resolve merge in setup.cfg and reduce base.py 

    assert_equal and assert_extension_array_equal were not needed to be overwritten. Instead they can be directly accessed from testing.
    @lukasbk
    lukasbk committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    a7fcf3f View commit details
    Browse the repository at this point in the history

  2. Fix stata files

    @lukasbk
    lukasbk committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    d5856b8 View commit details
    Browse the repository at this point in the history

  3. Change more references to tm

    @lukasbk
    lukasbk committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    2da8bad View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2019

  1. Merge master

    @lukasbk
    lukasbk committed Dec 15, 2019
    Configuration menu
    Copy the full SHA
    0309fe8 View commit details
    Browse the repository at this point in the history