mypy typing issues for decimal pandas/tests/extension/decimal/test_decimal.py

[yogendrasoni]

• xref Fix mypy errors for pandas\tests\* #28926
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[simonjayhawkins]

@yogendrasoni Thanks for the PR. A couple of suggestions.

[simonjayhawkins]

can you remove this entire section from setup.cfg

[simonjayhawkins]

instead of silencing the mypy errors can you make the signatures of assert_series_equal and assert_frame_equal compatible between BaseDecimal and BaseExtensionTests.

make the methods in BaseDecimal staticmethods and define the methods in BaseExtensionTests to be compatibile using *args and **kwargs, i.e.

    @staticmethod
    def assert_series_equal(left, right, *args, **kwargs):
        tm.assert_series_equal(left, right, *args, **kwargs)

    @staticmethod
    def assert_frame_equal(left, right, *args, **kwargs):
        tm.assert_frame_equal(left, right, *args, **kwargs)

[yogendrasoni]

tried putting staticmethod, BaseExtensionTests methods takes (left,right, some arguments) but BaseDecimal takes (left,right,*args,**kwargs) it is still showing incompatible by mypy, didn't find anything to solve this. I need to study more to solve this.

[WillAyd]

I think #28994 has the same issue. What error are you getting after trying what @simonjayhawkins suggested?

[simonjayhawkins]

yes we have two modules that are reporting mypy errors due to the same root issue.

[jbrockmendel]

@simonjayhawkins am i right in thinking that the # type: ignore this uses is something were trying pretty hard to avoid?

[simonjayhawkins]

@simonjayhawkins am i right in thinking that the # type: ignore this uses is something were trying pretty hard to avoid?

correct.

[WillAyd]

@yogendrasoni is this still active?

[jreback]

closing as stale, if you'ld like to continue, pls ping.