Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: Check for pytest.raises without context #25866

Merged
merged 2 commits into from
Mar 26, 2019
Merged

STY: Check for pytest.raises without context #25866

merged 2 commits into from
Mar 26, 2019

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Mar 25, 2019 •
edited
Loading

xref #24332

First commit adds the script code for checking. Remaining commits will fix any vestigial errors.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Code Style Code style, linting, code_checks labels Mar 25, 2019
@gfyoung gfyoung added this to the 0.25.0 milestone Mar 25, 2019
@pandas-dev pandas-dev deleted a comment from codecov bot Mar 25, 2019
@codecov
Copy link

codecov bot commented Mar 25, 2019 •
edited
Loading

Codecov Report

Merging #25866 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25866   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         175      175           
  Lines       52885    52885           
=======================================
  Hits        48380    48380           
  Misses       4505     4505
Flag Coverage Δ
#multiple 90.04% <ø> (ø) ⬆️
#single 41.82% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/computation/pytables.py 90.24% <0%> (-0.31%) ⬇️
pandas/util/testing.py 89.84% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6ccf6...2733901. Read the comment docs.

@pandas-dev pandas-dev deleted a comment from codecov bot Mar 25, 2019
@jreback jreback mentioned this pull request Mar 26, 2019
Closed
8 tasks
@gfyoung
Copy link
Member Author

gfyoung commented Mar 26, 2019

@jreback : All is green now. PTAL.

@jreback jreback merged commit 95c78d6 into pandas-dev:master Mar 26, 2019
@jreback
Copy link
Contributor

jreback commented Mar 26, 2019

thanks @gfyoung does this close the issue?

@gfyoung
Copy link
Member Author

gfyoung commented Mar 26, 2019 •
edited
Loading

@jreback : That number is a PR number (there was no issue for this).

@gfyoung gfyoung deleted the pytest-ctx-add branch March 26, 2019 22:49
@simonjayhawkins simonjayhawkins mentioned this pull request Mar 27, 2019
Closed
@simonjayhawkins simonjayhawkins mentioned this pull request May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gfyoung @jreback