Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #25262 on branch 0.24.x (REF/TST: resample/test_base.py) #25718

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #25262: REF/TST: resample/test_base.py

@lumberbot-app lumberbot-app bot added this to the 0.25.0 milestone Mar 13, 2019
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #25718 into 0.24.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.24.x   #25718   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         166      166           
  Lines       52430    52430           
=======================================
  Hits        48443    48443           
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.83% <ø> (ø) ⬆️
#single 42.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68278a8...9ff83de. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #25718 into 0.24.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.24.x   #25718   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         166      166           
  Lines       52430    52430           
=======================================
  Hits        48443    48443           
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.83% <ø> (ø) ⬆️
#single 42.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68278a8...9ff83de. Read the comment docs.

@jorisvandenbossche
Copy link
Member

@TomAugspurger why does this need to be backported? For the collection problems?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Mar 13, 2019 via email

@simonjayhawkins
Copy link
Member

@TomAugspurger : if this does solve the collection problem, we can close #25197.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Mar 14, 2019
@jreback jreback modified the milestones: 0.25.0, 0.24.3 Mar 14, 2019
@jreback
Copy link
Contributor

jreback commented Mar 18, 2019

is this mergable or should close?

@jreback jreback merged commit 1ec0472 into pandas-dev:0.24.x Mar 26, 2019
@jreback
Copy link
Contributor

jreback commented Mar 26, 2019

let's see if this works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants