TST/CLN: empty DataFrames and some 'empty' Series #25690
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25690 +/- ##
==========================================
+ Coverage 91.28% 91.28% +<.01%
==========================================
Files 173 173
Lines 52965 52965
==========================================
+ Hits 48348 48349 +1
+ Misses 4617 4616 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #25690 +/- ##
==========================================
+ Coverage 91.28% 91.28% +<.01%
==========================================
Files 173 173
Lines 52965 52965
==========================================
+ Hits 48348 48349 +1
+ Misses 4617 4616 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25690 +/- ##
==========================================
+ Coverage 91.47% 91.48% +<.01%
==========================================
Files 175 175
Lines 52885 52885
==========================================
+ Hits 48379 48380 +1
+ Misses 4506 4505 -1
Continue to review full report at Codecov.
|
|
this is fine. is it possible to have a code_checks rule to detect these (slightly tricky as you only want to disallow these in an assignment (and not a lambda). |
jreback
added
Testing
| lambda: DataFrame(data=[]), | ||
| lambda: DataFrame(data=(x for x in [])), | ||
| # these are NOT empty DataFrames | ||
| pytest.param(lambda: DataFrame([[]]), marks=pytest.mark.xfail( |
There was a problem hiding this comment.
Better to parametrize these in a separate test rather than supplying mark here
There was a problem hiding this comment.
I was just cautious of making actual behaviour tested and then tested behaviour becoming the accepted behaviour because it's tested. I'm not sure if the index differences are intentional.
There was a problem hiding this comment.
yeah i agree, can you separate these cases out
There was a problem hiding this comment.
can you update this and merge master, ping on green.
|
can you update |
have not looked into this yet, will circle back round after revisiting my other open PRs. |
|
thanks @simonjayhawkins yeah if you can think of a nice way to add to code_checks would be great. |
xref #24886 (comment)
have included Series constructed with an empty dict.
Series constructed with an empty list, tuple or generator are not the same as Series() or Series({}), so have not included them in this pass. (although for many tests the difference in the Index is not relevant)