Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #25024 on branch 0.24.x (REGR: fix read_sql delegation for queries on MySQL/pymysql) #25064

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Backport PR #25024 on branch 0.24.x (REGR: fix read_sql delegation for queries on MySQL/pymysql) #25064

merged 1 commit into from
Jan 31, 2019

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #25024: REGR: fix read_sql delegation for queries on MySQL/pymysql

@lumberbot-app lumberbot-app bot added this to the 0.24.1 milestone Jan 31, 2019
@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #25064 into 0.24.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.24.x   #25064   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         166      166           
  Lines       52397    52397           
=======================================
  Hits        48400    48400           
  Misses       3997     3997
Flag Coverage Δ
#multiple 90.79% <ø> (ø) ⬆️
#single 42.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3634b1...3ff1aad. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 31, 2019 •
edited
Loading

Codecov Report

Merging #25064 into 0.24.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.24.x   #25064   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         166      166           
  Lines       52397    52397           
=======================================
  Hits        48400    48400           
  Misses       3997     3997
Flag Coverage Δ
#multiple 90.79% <ø> (ø) ⬆️
#single 42.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3634b1...3ff1aad. Read the comment docs.

@gfyoung gfyoung added Regression Functionality that used to work in a prior pandas version IO SQL to_sql, read_sql, read_sql_query labels Jan 31, 2019
@gfyoung gfyoung merged commit 4f865c5 into pandas-dev:0.24.x Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
0.24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@meeseeksmachine @gfyoung @jorisvandenbossche