[DOC] Fix issues with DataFrame.aggregate page #24948
Conversation
Fixed some formatting issues. Description was gettign rendered in the wrong location. Moved a line from generic.py to frame.py to help with the rendering. Moved the description being clubbed with see also to doc string with the function declaration in frame.py
|
Hello @rotuna! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 27, 2019 at 04:48 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #24948 +/- ##
==========================================
+ Coverage 91.73% 91.73% +<.01%
==========================================
Files 173 173
Lines 52838 52839 +1
==========================================
+ Hits 48471 48473 +2
+ Misses 4367 4366 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24948 +/- ##
===========================================
- Coverage 92.37% 42.9% -49.48%
===========================================
Files 166 166
Lines 52388 52388
===========================================
- Hits 48396 22475 -25921
- Misses 3992 29913 +25921
Continue to review full report at Codecov.
|
The summary intended for DataFrame.aggregate was not rendered properly. Added a summary variable in the aggregate template in generic.py. Added an empty summary in all pages using the shared doc.
|
@rotuna any chance you could post the output of |
|
Sure |
|
Hi, I've attached the output for all the aggregate pages. I can attach the rendered HTML too if you want. The zip of the output files is here: Rendered HTML files are here: |
|
@WillAyd Do I need to make any further changes? |
|
Sorry missed previous ping - can you merge master and resolve conflicts? Will take a look after that |
|
@rotuna can you merge master? |
| If DataFrame.agg is called with several functions, returns a DataFrame | ||
| If Series.agg is called with single function, returns a scalar | ||
| If Series.agg is called with several functions, returns a Series. | ||
| - If DataFrame.agg is called with a single function, returns a Series |
There was a problem hiding this comment.
Can you use asterisks here instead?
There was a problem hiding this comment.
Also I think this will fail once #25132 gets merged. Give that a look to see how to handle
|
@rotuna looks like there's a merge conflict. Can you merge master & push the update? |
|
@rotuna can you merge master and resolve the conflict here? |
|
Closing as stale. Ping if you'd like to pick this back up |
Fixed some formatting issues. Description was gettign rendered in the
wrong location.
Moved a line from generic.py to frame.py to help with the rendering.
Moved the description being clubbed with see also to doc string with the
function declaration in frame.py
closes DOC: Removed duplicate doc line #24668
passes
git diff upstream/master -u -- "*.py" | flake8 --diff