Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: use pytest.raises context syntax (reshape) #24838

Merged
merged 4 commits into from
Jan 19, 2019
Merged

STY: use pytest.raises context syntax (reshape) #24838

merged 4 commits into from
Jan 19, 2019

Conversation

simonjayhawkins
Copy link
Member

xref #24332

@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #24838 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24838   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52382    52382           
=======================================
  Hits        48395    48395           
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 42.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/merge.py 94.4% <ø> (+0.13%) ⬆️
pandas/util/testing.py 88.04% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa05e54...e4fce9e. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 19, 2019 •
edited
Loading

Codecov Report

Merging #24838 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24838   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52382    52382           
=======================================
  Hits        48395    48395           
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 42.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/merge.py 94.4% <ø> (+0.13%) ⬆️
pandas/util/testing.py 88.04% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa05e54...20de62e. Read the comment docs.

@jreback jreback added Testing pandas testing functions or related to the test suite Code Style Code style, linting, code_checks labels Jan 19, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 19, 2019
@jreback jreback merged commit f78790f into pandas-dev:master Jan 19, 2019
@jreback
Copy link
Contributor

jreback commented Jan 19, 2019

thanks @simonjayhawkins keep em coming!

@jreback
Copy link
Contributor

jreback commented Jan 20, 2019

this broke a 3.6 build with older numpy; which we use when building wheels: https://travis-ci.org/MacPython/pandas-wheels/jobs/481944243

@simonjayhawkins can you do a followup to fix? not easy to test this.

@simonjayhawkins simonjayhawkins mentioned this pull request Jan 20, 2019
Merged
@simonjayhawkins simonjayhawkins deleted the cm-reshape branch January 20, 2019 22:31
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
STY: use pytest.raises context syntax (reshape) (pandas-dev#24838)
5ce011a
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
STY: use pytest.raises context syntax (reshape) (pandas-dev#24838)
4c2953c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @jreback