Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused kwarg #24695

Merged
merged 2 commits into from
Jan 10, 2019
Merged

remove unused kwarg #24695

merged 2 commits into from
Jan 10, 2019

Conversation

jbrockmendel
Copy link
Member

AFAICT klass is never passed to astype, so the kwarg can be removed.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

jbrockmendel
jbrockmendel commented Jan 10, 2019
View reviewed changes
pandas/core/internals/blocks.py
elif is_object_dtype(dtype):
klass = ObjectBlock
elif is_extension_array_dtype(dtype):
klass = ExtensionBlock
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone more familiar with this than me may want to double-check if these 7 lines are still needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @TomAugspurger recently modified this for Sparse

@jbrockmendel jbrockmendel reopened this Jan 10, 2019
@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #24695 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24695      +/-   ##
==========================================
+ Coverage   92.38%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52310    52310              
==========================================
+ Hits        48326    48327       +1     
+ Misses       3984     3983       -1
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 43.06% <71.42%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 94.3% <100%> (ø) ⬆️
pandas/util/testing.py 88.09% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56db9d...a70990d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 10, 2019 •
edited
Loading

Codecov Report

Merging #24695 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24695      +/-   ##
==========================================
+ Coverage   92.38%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52310    52310              
==========================================
+ Hits        48326    48327       +1     
+ Misses       3984     3983       -1
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 43.06% <71.42%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 94.3% <100%> (ø) ⬆️
pandas/util/testing.py 88.09% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56db9d...a70990d. Read the comment docs.

@jreback jreback added the Internals Related to non-user accessible pandas implementation label Jan 10, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 10, 2019
@jreback jreback merged commit 4bd286a into pandas-dev:master Jan 10, 2019
@jreback
Copy link
Contributor

jreback commented Jan 10, 2019

thanks!

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
remove unused kwarg (pandas-dev#24695)
a4897d0
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
remove unused kwarg (pandas-dev#24695)
b3280eb
@jbrockmendel jbrockmendel deleted the noklass branch April 5, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback