Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Remove doc spellcheck #24287

Merged
merged 1 commit into from
Dec 15, 2018
Merged

DOC: Remove doc spellcheck #24287

merged 1 commit into from
Dec 15, 2018

Conversation

datapythonista
Copy link
Member

@datapythonista datapythonista commented Dec 14, 2018

The spellcheck system was implemented, but with dependencies (i.e. enchant) that are no longer maintained, and there is no reasonable way to set them up. This means that can't be added to the CI, and can't be even set up into our local environments with a decent amount of work installing dependencies manually (I didn't succeed).

The PR that was trying to finish the work on the spellcheck, #21402, was finally discarded, but part of the stuff is still in sphinx, just generating a warning when trying to get the sphinx extension.

This PR removes it.

@pep8speaks
Copy link

Hello @datapythonista! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #24287 into master will decrease coverage by 49.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24287       +/-   ##
===========================================
- Coverage   92.22%      43%   -49.22%     
===========================================
  Files         162      162               
  Lines       51824    51824               
===========================================
- Hits        47795    22289    -25506     
- Misses       4029    29535    +25506
Flag Coverage Δ
#multiple ?
#single 43% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-98.65%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0fa8e...992a4ad. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #24287 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24287   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         162      162           
  Lines       51824    51824           
=======================================
  Hits        47795    47795           
  Misses       4029     4029
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0fa8e...65b7493. Read the comment docs.

@datapythonista datapythonista changed the title DOC: Remove doc spellcheck and make doc build fail DOC: Remove doc spellcheck Dec 15, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 15, 2018
@jreback jreback merged commit 8076a2f into pandas-dev:master Dec 15, 2018
@jreback
Copy link
Contributor

jreback commented Dec 15, 2018

thanks!

@jreback
Copy link
Contributor

jreback commented Dec 15, 2018

can you do a followup to remove sphinxcontrib-spelling from any of the ci & environment.yml & also remove the spelling section from the contributing guide. thanks.

@datapythonista
Copy link
Member Author

Thanks for pointing out @jreback, I totally forgot about it (and I double checked, and there were also some code left in doc/make.py I wasn't aware of).

I opened this follow up: #24299

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants