Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: run setitem tests for IntegerArray #24054

Merged
merged 2 commits into from
Dec 3, 2018

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Dec 2, 2018

No description provided.

@jreback jreback added Testing pandas testing functions or related to the test suite ExtensionArray Extending pandas with custom dtypes or arrays. labels Dec 2, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 2, 2018
@pep8speaks
Copy link

Hello @jreback! Thanks for submitting the PR.

@jreback
Copy link
Contributor Author

jreback commented Dec 2, 2018

noticed this when merging #23991

@TomAugspurger is itemsize stricly required in Dtype? if so then i will mention it in the doc-string.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@f06b969). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #24054   +/-   ##
=========================================
  Coverage          ?   42.44%           
=========================================
  Files             ?      161           
  Lines             ?    51564           
  Branches          ?        0           
=========================================
  Hits              ?    21887           
  Misses            ?    29677           
  Partials          ?        0
Flag Coverage Δ
#single 42.44% <50%> (?)
Impacted Files Coverage Δ
pandas/core/arrays/integer.py 38.06% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06b969...0ec244a. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #24054 into master will increase coverage by 49.86%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24054       +/-   ##
===========================================
+ Coverage   42.38%   92.25%   +49.86%     
===========================================
  Files         161      161               
  Lines       51699    51701        +2     
===========================================
+ Hits        21913    47696    +25783     
+ Misses      29786     4005    -25781
Flag Coverage Δ
#multiple 90.65% <100%> (?)
#single 42.38% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/integer.py 95.5% <100%> (+57.52%) ⬆️
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.3% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 93.24% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 58.36% <0%> (+8.17%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
pandas/core/api.py 100% <0%> (+14.81%) ⬆️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06b969...336ecfa. Read the comment docs.

@TomAugspurger
Copy link
Contributor

itemsize isn't part of the interface. I'm not sure it could be added, since we may have variable-width EAs.

Probably want to add a docstring for your Int*Dtype.itemsize, since once won't be inherited.

LGTM otherwise.

@jreback
Copy link
Contributor Author

jreback commented Dec 3, 2018

not sure why azure is not running on the personal builds. but this is ready @TomAugspurger

@TomAugspurger
Copy link
Contributor

Agreed. We may want to hold off on merging larger changes, since I believe linting is now on azure, but this LGTM.

@TomAugspurger TomAugspurger merged commit 08395af into pandas-dev:master Dec 3, 2018
@TomAugspurger
Copy link
Contributor

But let's see if it runs for the merge build. If so, then we can merge things and followup as needed.

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
* TST: run setitem tests for IntegerArray

* doc-string
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
* TST: run setitem tests for IntegerArray

* doc-string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants