Ensure that DatetimeArray keeps reference to original data #23956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 49f6495ba5ceef35a7a962f20e8b863c544592b7)
TomAugspurger
added
Datetime
|
Hello @TomAugspurger! Thanks for submitting the PR.
|
TomAugspurger
commented
Nov 27, 2018
| @@ -99,11 +99,11 @@ def ensure_datetime64ns(arr: ndarray, copy: bool=True): | |||
|
|
|||
| ivalues = arr.view(np.int64).ravel() | |||
|
|
|||
| result = np.empty(shape, dtype='M8[ns]') | |||
| result = np.empty(shape, dtype=NS_DTYPE) | |||
There was a problem hiding this comment.
To be clear: this change is cosmetic. The real change is below.
Codecov Report
@@ Coverage Diff @@
## master #23956 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 161 161
Lines 51471 51471
=======================================
Hits 47515 47515
Misses 3956 3956
Continue to review full report at Codecov.
|
jreback
requested changes
Nov 28, 2018
Added tests for copy
jreback
approved these changes
Nov 28, 2018
|
lgtm. |
|
thanks! |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 49f6495ba5ceef35a7a962f20e8b863c544592b7)
This avoids a segfault I (and possibly @jbrockmendel) were seeing on our datetimearray branches from us freeing a region of memory we didn't allocate.
I haven't really groked things yet, but
_libs/reduction.pyx::Slideris doing some strange things with the data of the array passed to it (overwriting the buffer's.dataand.stridesattributes). One of the arguments,buff, is a slice on the original index. It seems like ensuring that the ndarray backing the DatetimeArray sliced index is the same as the original index avoids the segfault.