-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: concat warning bubbling up through str.cat #23725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @h-vetinari! Thanks for submitting the PR.
|
Aaaaaand, another flaky hypothesis failure. |
gfyoung
added
Reshaping
Concat, Merge/Join, Stack/Unstack, Explode
Strings
String extension data type and string data
labels
Nov 16, 2018
Codecov Report
@@ Coverage Diff @@
## master #23725 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 161 161
Lines 51383 51383
=======================================
Hits 47404 47404
Misses 3979 3979
Continue to review full report at Codecov.
|
thanks! |
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an unexpected realisation from #23723 -- the change of
pd.concat
in #20613 to addsort
and raise a warning if it's not specified was not caught in the.str.cat
code, because it was being shadowed (apparently in all relevant tests) by anotherFutureWarning
that's being raised ifjoin
is not specified (from #20347).This PR only adds the kwarg to the
.str.cat
internals where necessary.Example from #23723: