More helpful Stata object dtype error. (#23572) #23646
Conversation
|
Hello @kylebarron! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23646 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 161 161
Lines 51317 51317
=======================================
Hits 47338 47338
Misses 3979 3979
Continue to review full report at Codecov.
|
| @@ -466,6 +466,12 @@ def parse_dates_safe(dates, delta=False, year=False, days=False): | |||
| """ | |||
|
|
|||
|
|
|||
| general_object_array_error = """ | |||
| Writing non-string object columns is not supported. Column '%s' does not | |||
There was a problem hiding this comment.
We've been moving to new-style format strings. Could you change the %s to {}?
Also for relatively simply error message like this, having the message next to where it's raised helps keep the code clearer. Could you define this message where it's used? Use params to wrap lines in the source
msg = (
"Writing non-string... "
" ... "
)
raise ValueError(msg)
|
Yes. The error I gave has more detail and incorporates more of the consensus about what is helpful (I think) |
git diff upstream/master -u -- "*.py" | flake8 --diffThis changes the error message shown when trying to write a non-string column with dtype
objectto Stata. It also includes the name of the offending column in the error message.