Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: remove incorrect usages of com.AbstractMethodError #23625

Merged
merged 3 commits into from
Nov 12, 2018
Merged

CLN: remove incorrect usages of com.AbstractMethodError #23625

merged 3 commits into from
Nov 12, 2018

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@jreback jreback added Error Reporting Incorrect or improved errors from pandas Clean labels Nov 11, 2018
@jreback jreback added this to the 0.24.0 milestone Nov 11, 2018
@jreback
Copy link
Contributor

jreback commented Nov 11, 2018

lgtm. ping on green.

@fortrue23
Copy link

Please cancela pool thanks

@codecov
Copy link

codecov bot commented Nov 12, 2018 •
edited
Loading

Codecov Report

Merging #23625 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23625      +/-   ##
==========================================
- Coverage   92.24%   92.24%   -0.01%     
==========================================
  Files         161      161              
  Lines       51326    51317       -9     
==========================================
- Hits        47347    47338       -9     
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.63% <100%> (-0.01%) ⬇️
#single 42.31% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby/generic.py 87.07% <ø> (ø) ⬆️
pandas/io/common.py 70.54% <ø> (-0.23%) ⬇️
pandas/io/html.py 91.2% <ø> (-0.06%) ⬇️
pandas/core/generic.py 96.81% <ø> (ø) ⬆️
pandas/plotting/_core.py 83.63% <ø> (ø) ⬆️
pandas/core/groupby/ops.py 96.79% <ø> (ø) ⬆️
pandas/io/parquet.py 84.61% <ø> (-0.15%) ⬇️
pandas/core/groupby/groupby.py 96.51% <ø> (ø) ⬆️
pandas/io/json/json.py 93.09% <ø> (-0.02%) ⬇️
pandas/io/parsers.py 95.55% <ø> (-0.01%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011b79f...b49c194. Read the comment docs.

@jbrockmendel
Copy link
Member Author

Ping

@jreback
Copy link
Contributor

jreback commented Nov 12, 2018

can you rebase

@jorisvandenbossche jorisvandenbossche changed the title REF: remove incorrect usages of com.AbstractMethodError CLN: remove incorrect usages of com.AbstractMethodError Nov 12, 2018
@jreback jreback merged commit c738523 into pandas-dev:master Nov 12, 2018
@jreback
Copy link
Contributor

jreback commented Nov 12, 2018

thanks!

@jbrockmendel jbrockmendel deleted the nocom branch November 12, 2018 18:10
thoo added a commit to thoo/pandas that referenced this pull request Nov 12, 2018
@thoo
Merge remote-tracking branch 'upstream/master' into io_csv_docstring_…
63c6d84 
…fixed

* upstream/master:
  DOC: avoid SparseArray.take error (pandas-dev#23637)
  CLN: remove incorrect usages of com.AbstractMethodError (pandas-dev#23625)
  DOC: Adding validation of the section order in docstrings (pandas-dev#23607)
  BUG: Don't over-optimize memory with jagged CSV (pandas-dev#23527)
  DEPR: Deprecate usecols as int in read_excel (pandas-dev#23635)
  More helpful Stata string length error. (pandas-dev#23629)
  BUG: astype fill_value for SparseArray.astype (pandas-dev#23547)
  CLN: datetimelike arrays: isort, small reorg (pandas-dev#23587)
  CI: Check in the CI that assert_raises_regex is not being used (pandas-dev#23627)
  CLN:Remove unused **kwargs from user facing methods (pandas-dev#23249)
avolkov pushed a commit to avolkov/pandas that referenced this pull request Nov 13, 2018
@jbrockmendel
CLN: remove incorrect usages of com.AbstractMethodError (pandas-dev#2…
22ee6fb 
…3625)
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
@jbrockmendel @JustinZhengBC
CLN: remove incorrect usages of com.AbstractMethodError (pandas-dev#2…
fdda5d7 
…3625)
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@jbrockmendel @tm9k1
CLN: remove incorrect usages of com.AbstractMethodError (pandas-dev#2…
052f4c4 
…3625)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
CLN: remove incorrect usages of com.AbstractMethodError (pandas-dev#2…
4dbfa97 
…3625)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
CLN: remove incorrect usages of com.AbstractMethodError (pandas-dev#2…
b6bf7e0 
…3625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @pep8speaks @jreback @fortrue23