TST: Fix xfailing DataFrame arithmetic tests by transposing #23620
Conversation
|
Hello @jbrockmendel! Thanks for updating the PR.
Comment last updated on November 11, 2018 at 20:09 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #23620 +/- ##
==========================================
+ Coverage 92.23% 92.23% +<.01%
==========================================
Files 161 161
Lines 51288 51290 +2
==========================================
+ Hits 47304 47306 +2
Misses 3984 3984
Continue to review full report at Codecov.
|
gfyoung
added
Testing
| rng = tm.box_expected(rng, box_with_datetime) | ||
|
|
||
| # FIXME: calling with transpose=True raises ValueError | ||
| rng = tm.box_expected(rng, box, transpose=False) |
There was a problem hiding this comment.
Can we potentially have xfail tests for these?
There was a problem hiding this comment.
Good idea. I've implemented this for some of these (will push shortly). For others (particularly ones using box_with_period or box_with_datetimes instead of box) doing that becomes much hairier and I'm inclined to leave the FIXME notes for the time being.
|
ok ping on green. (also if you have a chance to find the transpose on tz-DTI in a DataFrame issue) and link would be great. |
|
ping |
…fixed * upstream/master: DOC: Enhancing pivot / reshape docs (pandas-dev#21038) TST: Fix xfailing DataFrame arithmetic tests by transposing (pandas-dev#23620) BUILD: Simplifying contributor dependencies (pandas-dev#23522) BUG/REF: TimedeltaIndex.__new__ (pandas-dev#23539) BUG: Casting tz-aware DatetimeIndex to object-dtype ndarray/Index (pandas-dev#23524) BUG: Delegate more of Excel parsing to CSV (pandas-dev#23544) API: DataFrame.__getitem__ returns Series for sparse column (pandas-dev#23561) CLN: use float64_t consistently instead of double, double_t (pandas-dev#23583) DOC: Fix Order of parameters in docstrings (pandas-dev#23611) TST: Unskip some Categorical Tests (pandas-dev#23613) TST: Fix integer ops comparison test (pandas-dev#23619)
* upstream/master: BUG: Don't over-optimize memory with jagged CSV (pandas-dev#23527) DEPR: Deprecate usecols as int in read_excel (pandas-dev#23635) More helpful Stata string length error. (pandas-dev#23629) BUG: astype fill_value for SparseArray.astype (pandas-dev#23547) CLN: datetimelike arrays: isort, small reorg (pandas-dev#23587) CI: Check in the CI that assert_raises_regex is not being used (pandas-dev#23627) CLN:Remove unused **kwargs from user facing methods (pandas-dev#23249) DOC: Enhancing pivot / reshape docs (pandas-dev#21038) TST: Fix xfailing DataFrame arithmetic tests by transposing (pandas-dev#23620)
git diff upstream/master -u -- "*.py" | flake8 --diff