Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Delegate more of Excel parsing to CSV #23544

Merged
merged 1 commit into from
Nov 11, 2018

Commits on Nov 11, 2018

  1. BUG: Delegate more of Excel parsing to CSV

    The idea is that we read the Excel file,
    get the data, and then let the TextParser
    handle the reading and parsing.
    
    We shouldn't be doing a lot of work that
    is already defined in parsers.py
    
    In doing so, we identified several bugs:
    
    * index_col=None was not being respected
    
    * usecols behavior was inconsistent with
    that of read_csv for list of strings and
    callable inputs
    
    * usecols was not being validated as proper
    Excel column names when passed as a string.
    
    Closes pandas-devgh-18273.
    Closes pandas-devgh-20480.
    gfyoung committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    a36aa76 View commit details
    Browse the repository at this point in the history