Fix+Test Timedelta.__mul__(nan) #23342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jbrockmendel! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23342 +/- ##
=========================================
Coverage ? 92.22%
=========================================
Files ? 169
Lines ? 51217
Branches ? 0
=========================================
Hits ? 47236
Misses ? 3981
Partials ? 0
Continue to review full report at Codecov.
|
jreback
requested changes
Oct 26, 2018
| @@ -328,6 +336,16 @@ def test_td_div_numeric_scalar(self): | |||
| assert isinstance(result, Timedelta) | |||
| assert result == Timedelta(days=2) | |||
|
|
|||
| @pytest.mark.parametrize('nan', [np.nan, np.float64('NaN'), float('nan')]) | |||
There was a problem hiding this comment.
Yes, but it also includes several scalars we dont want to include here.
| @@ -277,6 +277,14 @@ def test_td_mul_nat(self, op, td_nat): | |||
| with pytest.raises(TypeError): | |||
| op(td, td_nat) | |||
|
|
|||
| @pytest.mark.parametrize('nan', [np.nan, np.float64('NaN'), float('nan')]) | |||
jreback
added
Numeric Operations
jreback
approved these changes
Oct 28, 2018
|
thanks |
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically,
np.float64("NAN")which in master gets caught by thehasattr(other, "dtype")branch and incorrectly returnsnp.timedelta64("NaT", "ns")instead ofNaTgit diff upstream/master -u -- "*.py" | flake8 --diff