Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: SparseArray imports #23329

Merged
merged 5 commits into from
Oct 26, 2018
Merged

REF: SparseArray imports #23329

merged 5 commits into from
Oct 26, 2018

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Oct 25, 2018 •
edited
Loading

arrays/sparse.py was doing an import pandas as pd, which is prone to cause circular imports. I've eliminated that import and updated the namespaces appropriately (NaT, isna, algos.unique / factorize).

Also updated setup.cfg to check the import order in arrays/sparse.py.

@pep8speaks
Copy link

Hello @TomAugspurger! Thanks for submitting the PR.

@TomAugspurger TomAugspurger added Refactor Internal refactoring of code Sparse Sparse Data Type labels Oct 25, 2018
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Oct 25, 2018
@alimcmaster1
Copy link
Member

LGTM - thanks for cleaning up the imports using isort too :)

@alimcmaster1
Copy link
Member

I think if you remove one of the newlines after from pandas.errors import PerformanceWarning in sparse.py that should fix the isort failure on CI :)

@codecov
Copy link

codecov bot commented Oct 25, 2018 •
edited
Loading

Codecov Report

Merging #23329 into master will not change coverage.
The diff coverage is 96%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23329   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         169      169           
  Lines       51258    51258           
=======================================
  Hits        47274    47274           
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.66% <96%> (ø) ⬆️
#single 42.23% <64%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 93.91% <100%> (-0.01%) ⬇️
pandas/core/arrays/sparse.py 91.84% <95.83%> (ø) ⬆️
pandas/core/arrays/datetimes.py 97.46% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437f31c...dad49d0. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

Thanks.

Merging tonight, since this is a straight refactor, and I have another PR building on top if it.

@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

pls merge master ping on green.

@TomAugspurger
Copy link
Contributor Author

CircleCI seems to be ~10 hours behind. OK to cancel those, since we're dropping (most) of them anyway? I'll be free to clean things up this afternoon if we accidentally break anything.

@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

sure

@jorisvandenbossche jorisvandenbossche merged commit 48782a8 into pandas-dev:master Oct 26, 2018
thoo added a commit to thoo/pandas that referenced this pull request Oct 26, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into fix_import_format…
a929602 
…_pr4

* repo_org/master:
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
thoo added a commit to thoo/pandas that referenced this pull request Oct 26, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into fix_import_format…
9622556 
…_series_pr1

* repo_org/master:
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
thoo added a commit to thoo/pandas that referenced this pull request Oct 26, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into fix_import_format…
ebe9fd7 
…_pr2

* repo_org/master:
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
  Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341)
  TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304)
  API: Add sparse Acessor (pandas-dev#23183)
  PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)
thoo added a commit to thoo/pandas that referenced this pull request Oct 27, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into Warning_prefix_pa…
cc5dc0f 
…ndas

* repo_org/master: (23 commits)
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
  Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341)
  TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304)
  API: Add sparse Acessor (pandas-dev#23183)
  PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)
  fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302)
  BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317)
  TST: re-enable gbq tests (pandas-dev#23303)
  Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311)
  isort imports-io (pandas-dev#23332)
  DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279)
  REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)
  DOC: Added Examples for Series max (pandas-dev#23298)
  API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644)
  BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291)
  ...
thoo added a commit to thoo/pandas that referenced this pull request Oct 27, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into check_np_pd_fromE…
881b011 
…xamples

* repo_org/master: (83 commits)
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
  Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341)
  TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304)
  API: Add sparse Acessor (pandas-dev#23183)
  PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)
  fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302)
  BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317)
  TST: re-enable gbq tests (pandas-dev#23303)
  Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311)
  isort imports-io (pandas-dev#23332)
  DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279)
  REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)
  DOC: Added Examples for Series max (pandas-dev#23298)
  API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644)
  BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291)
  ...
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@TomAugspurger @tm9k1
REF: SparseArray imports (pandas-dev#23329)
c4bce66
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
REF: SparseArray imports (pandas-dev#23329)
9d0a1d7
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
REF: SparseArray imports (pandas-dev#23329)
843be55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor Internal refactoring of code Sparse Sparse Data Type
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@TomAugspurger @pep8speaks @alimcmaster1 @jreback @jorisvandenbossche