Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST/CLN: Fixturize tests/frame/test_block_internals.py #22926

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

makbigc
Copy link
Contributor

@makbigc makbigc commented Oct 1, 2018

@pep8speaks
Copy link

Hello @makbigc! Thanks for submitting the PR.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 7, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 7, 2018
@jreback
Copy link
Contributor

jreback commented Oct 7, 2018

can you rebase and ping on green.

@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #22926 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22926   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files         170      170           
  Lines       51073    51073           
=======================================
  Hits        47056    47056           
  Misses       4017     4017
Flag Coverage Δ
#multiple 90.56% <ø> (ø) ⬆️
#single 42.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d8e78...3a3b107. Read the comment docs.

@makbigc
Copy link
Contributor Author

makbigc commented Oct 13, 2018

@jreback Thanks for your review. Rebased.

@jreback jreback merged commit 2f05cc8 into pandas-dev:master Oct 14, 2018
@jreback
Copy link
Contributor

jreback commented Oct 14, 2018

thanks @makbigc keep em coming!

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants