Close ZipFile in compression test

[TomAugspurger]

Maybe fixes #22675
Maybe fixed #22682

[pep8speaks]

Hello @TomAugspurger! Thanks for submitting the PR.

• There are no PEP8 issues in the file pandas/tests/io/test_pickle.py !

• There are no PEP8 issues in the file pandas/util/testing.py !

• Complete extra results for this file :

file_to_check.py:2442:-258: W605 invalid escape sequence '('
file_to_check.py:2442:-255: W605 invalid escape sequence ')'

---

[TomAugspurger]

@Zac-HD any thoughts on this hypothesis failures?

__________________________ test_tick_equality[Milli] ___________________________

cls = <class 'pandas.tseries.offsets.Milli'>

    @pytest.mark.parametrize('cls', tick_classes)
>   @example(n=2, m=3)
    @given(n=st.integers(-999, 999), m=st.integers(-999, 999))
    def test_tick_equality(cls, n, m):
E   hypothesis.errors.FailedHealthCheck: Data generation is extremely slow: Only produced 6 valid examples in 1.20 seconds (0 invalid ones and 0 exceeded maximum size). Try decreasing size of the data you're generating (with e.g.max_size or max_leaves parameters).
E   See https://hypothesis.readthedocs.io/en/latest/healthchecks.html for more information about this. If you want to disable just this health check, add HealthCheck.too_slow to the suppress_health_check settings for this test.

We've set that value in pandas/conftest.py

pandas/pandas/conftest.py

Line 13 in c040353

hypothesis.settings.suppress_health_check = (hypothesis.HealthCheck.too_slow,)

, is that correct?

[Zac-HD]

Ah, not quite - you need to assign to hypothesis.settings.default.suppress_health_check. At this point though I'd suggest

hypothesis.settings.register_profile(
    "ci", 
    suppress_health_check=(hypothesis.HealthCheck.too_slow,)
) 
hypothesis.settings.load_profile("ci")

might be less error-prone, and easier to add to in future!

[codecov]

Codecov Report

Merging #22679 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22679   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         169      169           
  Lines       50715    50715           
=======================================
  Hits        46747    46747           
  Misses       3968     3968

Flag	Coverage Δ
#multiple	90.58% <ø> (ø)	⬆️
#single	42.35% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/util/testing.py	85.96% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c040353...57f4a5a. Read the comment docs.

[WillAyd]

Could we alternately just bump the minimum version of xlrd? 1.0.0 is over 2 years old at this point. Only 1.1.0 has been released since then but even that is over a year old now

[TomAugspurger]

Thought about it, though this seemed easier for now. I don't have a strong preference.

[Zac-HD]

@TomAugspurger - FYI HypothesisWorks/hypothesis#1572 will ensure that settings issue can't come back.

[TomAugspurger]

Merging this in an hour if there are no objections, as this is causing issues on master.

For now I'm ok with just skipping those tests @WillAyd, but I'm not at all against bumping our excel-related minimum versions and doing a bit of a cleanup (in a separate PR 😄).