Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: factor apply out of frame.py #18754

Merged
merged 3 commits into from
Dec 14, 2017
Merged

CLN: factor apply out of frame.py #18754

merged 3 commits into from
Dec 14, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Dec 13, 2017

xref #18577

@jreback jreback added Clean Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Dec 13, 2017
@jreback jreback added this to the 0.22.0 milestone Dec 13, 2017
@jreback
Copy link
Contributor Author

jreback commented Dec 13, 2017

this is a factoring out of the apply code to a separate module. Then in #18577 can refactor properly to handle the many cases.

This doesn't change any functionailty or API.

cc @jorisvandenbossche @chris-b1

@codecov
Copy link

codecov bot commented Dec 13, 2017

Codecov Report

Merging #18754 into master will decrease coverage by <.01%.
The diff coverage is 99.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18754      +/-   ##
==========================================
- Coverage   91.61%    91.6%   -0.01%     
==========================================
  Files         153      154       +1     
  Lines       51363    51423      +60     
==========================================
+ Hits        47058    47108      +50     
- Misses       4305     4315      +10
Flag Coverage Δ
#multiple 89.47% <99.45%> (+0.01%) ⬆️
#single 40.81% <56.83%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/sparse/frame.py 94.8% <100%> (+0.02%) ⬆️
pandas/core/frame.py 97.68% <100%> (-0.23%) ⬇️
pandas/core/apply.py 99.42% <99.42%> (ø)
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9705a48...0f5e6ae. Read the comment docs.

@jreback jreback merged commit 76b35c6 into pandas-dev:master Dec 14, 2017
@jorisvandenbossche
Copy link
Member

+1, looks like a good refactor!
Can you add some docstrings when working further on it?

@jreback
Copy link
Contributor Author

jreback commented Dec 14, 2017

yep next pr
going to rip this apart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants