Fix bug where offset.copy() != offset #17452
Merged
+115
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test that will currently fail Make some attributes into cache_readonlys
|
Hello @jbrockmendel! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on September 14, 2017 at 16:17 Hours UTC |
jreback
reviewed
Sep 7, 2017
| @@ -1952,6 +1952,10 @@ def _check_roundtrip(obj): | |||
| _check_roundtrip(self._object(2)) | |||
| _check_roundtrip(self._object() * 2) | |||
|
|
|||
| def test_copy(self): | |||
There was a problem hiding this comment.
add the issue number (or pr number in this case) as a comment
|
is this orthogonal on #17458 ? |
|
Yes. They're related in spirit, but need to be fixed separately. |
Codecov Report
@@ Coverage Diff @@
## master #17452 +/- ##
==========================================
+ Coverage 91.15% 91.2% +0.04%
==========================================
Files 163 163
Lines 49587 49604 +17
==========================================
+ Hits 45203 45243 +40
+ Misses 4384 4361 -23
Continue to review full report at Codecov.
|
|
thanks; normally I would ask for a whatsnew entry, but I think this is fine. |
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test that will currently fail
Make some attributes into cache_readonlys
Last one for now.
git diff upstream/master -u -- "*.py" | flake8 --diff