Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define plot methods in class definitions #16913

Closed
wants to merge 3 commits into from
Closed

Define plot methods in class definitions #16913

wants to merge 3 commits into from

Commits on Jul 13, 2017

  1. Define plot methods in class definitions 

    instead of pinning them to Series/DataFrame at the bottom of the files.

(For reasons I dont quite get) Importing pandas.plotting._core at the top of core.series
instead of near the bottom causes a circular-import problem.  Avoided this by delaying
import from core.series inside plotting._tools and plotting._core.
    @jbrockmendel
    jbrockmendel committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    4a966fd View commit details
    Browse the repository at this point in the history

  2. Avoid imports of Series/DataFrame by checking isinstance against ABCFoo

    @jbrockmendel
    jbrockmendel committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    58f3a44 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2017

  1. Fix missing import of ABCIndex

    @jbrockmendel
    jbrockmendel committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    3d5559f View commit details
    Browse the repository at this point in the history