DOC: Demo incorporating pytest into test classes #15989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
testing-doc-patches
branch
from
9408578
to
90c2fbc
Compare
jreback
added
Docs
Testing
jreback
reviewed
Apr 13, 2017
doc/source/contributing.rst
Outdated
| @@ -701,6 +701,18 @@ Tests that we have ``parametrized`` are now accessible via the test name, for ex | |||
| test_cool_feature.py::test_dtypes[int8] PASSED | |||
| test_cool_feature.py::test_series[int8] PASSED | |||
|
|
|||
| Sometimes, it does make sense to bundle test functions together into a single class, either because the test file is testing multiple functions from a single module, and | |||
There was a problem hiding this comment.
can you make this a ::note ?
There was a problem hiding this comment.
actually, let's split this out to a section after 'Writing Tests' and before 'Parametrize' (you may want to move some prose from Parametrize that is related to this as well).
|
nice picture! |
The original photo showed the CI GitHub UI for an owner of the repository, which is not representative of what most contributors will see.
gfyoung
force-pushed
the
testing-doc-patches
branch
from
90c2fbc
to
6504c2d
Compare
gfyoung
force-pushed
the
testing-doc-patches
branch
from
6504c2d
to
b0c656e
Compare
|
@jreback All comments addressed. Ready to merge if nothing else. |
|
thanks! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory. Also changes CI GitHub UI photo to illustrate what most users (who are non-owners) will see (i.e. no "squash and merge").
#15987 (comment)