DOC: fixed using IP.prompt_manager which is removed from IPython 5.x #14004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znmean
changed the title
Current coverage is 85.28% (diff: 100%)@@ master #14004 diff @@
==========================================
Files 139 139
Lines 50241 50241
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42849 42849
Misses 7392 7392
Partials 0 0
|
| reset the execution count if we haven't processed this doc | ||
| NOTE: this may be borked if there are multiple seen_doc tmp files | ||
| check time stamp? | ||
| """ |
There was a problem hiding this comment.
can you leave this as # comments? (that's how multiline comments in the codebase are done """ is used for docstrings)
|
Thanks! |
class promptManager has removed in IPython 5.x, but this file still using that class, so it makes AttributeError. close pandas-dev#14003
znmean
force-pushed
the
shiny-new-feature
branch
from
548bd1a
to
34acf67
Compare
as it is not a user facing bug fix. closes pandas-dev#14003
|
Thanks! Done what you said.
|
|
@znmean Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffthis PR was made during PyCon APAC, pandas sprint
thanks