TST: Move plotting related tests to tests/plotting

[sinhrks]

• related to CLN: move plotting funcs to pd.plotting #13579
• tests passed
• passes git diff upstream/master | flake8 --diff

Because test_graphics is getting huge, split them based on data types under tests/plotting to make visualization related tests easier.

[jorisvandenbossche]

@sinhrks Looks good!

While we are in splitting modus, maybe also split the tests for 'other' dataframe/series methods (hist/boxplot) on the one hand, and the 'misc' functions on the other hand?

[jorisvandenbossche]

In this file it makes maybe more sense to split the tests in classes regarding hist vs boxplot tests, instead of series vs dataframe tests?

[sinhrks]

good idea. How about the following structure?

• .plot (previously test_graphics)
  • test_series
  • test_frame
  • test_groupby
• others (previously test_graphics_others)
  • test_legacy_hist
  • test_legacy_boxplot
  • test_misc

CC: @TomAugspurger

[TomAugspurger]

Only issue with that is the tests that use the data structures from setUp. Could make a common base class for those.

[jorisvandenbossche]

@TomAugspurger I don't think that is a problem, indeed easy to make a base class, and there is already a common file

@sinhrks Is there a reason to call it test_legacy_hist instead of test_hist? As we did not really officially deprecate them? And they are still used in the docs (but that is a very minor comment :-))

[sinhrks]

Not specific, I intended to clarify the differences between normal plot and boxplot/hist methods. Using boxplot_method and others.

[jorisvandenbossche]

And travis is failing because of lint issues

[codecov-io]

Current coverage is 84.38%

Merging #13621 into master will not change coverage

@@             master     #13621   diff @@
==========================================
  Files           142        142          
  Lines         51235      51235          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43235      43235          
  Misses         8000       8000          
  Partials          0          0          

Powered by Codecov. Last updated by c9a27ed...89c8b13

[sinhrks]

Updated to use following file names:

• .plot (previously test_graphics)
  • test_series
  • test_frame
  • test_groupby
• others (previously test_graphics_others)
  • test_hist_method
  • test_boxplot_method
  • test_misc

[jreback]

@sinhrks this is going to conflict with #13147

If you prefer I can rebase after we merge this, or is other way around ok?

[sinhrks]

I'm willing to rebase after #13147:)

[jorisvandenbossche]

Question: do we actually want it in tests/plotting or in plotting/tests ? We seem to vary a bit between different submodules (eg tseries, tools, io have their tests inside the module, which I pesonally like)

[sinhrks]

Whichever possible, pandas/tools/tests/plotting or pandas/tests/plotting. Newly created submodules (like indexes, types ) have its tests under pandas/tests/.

[jorisvandenbossche]

I actually meant pandas/plotting/tests (in the understanding that you were planning to move the plotting code to pandas/plotting in another PR).
I personally like that tests are close the the implementation, certainly for things that are rather independent modules (like io, and which is the case for plotting as well I think).

[sinhrks]

Yeah it'll be a goal if there is no objections. Shall we move pandas/plotting/tests in this PR (leaving the submodule itself empty), then move actual scripts in #13579 (split for review purpose)?

[sinhrks]

Would like to decide the (temporary) namespace to work on. I'm +1 for pandas/tests/plotting for now, and moving pandas/plotting/tests once ready (as moved files are easy to compare different from splitting).

[jorisvandenbossche]

That's fine for me. This is ready to merge then?

[sinhrks]

@jorisvandenbossche yes, related files are not updated after the previous rebase.

[jorisvandenbossche]

Merging then!