TST: reorganize tools.tests #13619
Merged
TST: reorganize tools.tests #13619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Testing
|
Looks good! |
Current coverage is 84.38%@@ master #13619 diff @@
==========================================
Files 142 142
Lines 51225 51225
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43225 43225
Misses 8000 8000
Partials 0 0
|
|
lgtm, prob will require rebase after #13147 |
|
Thanks @sinhrks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffmerge,joinandconcatrelated tests are mixed each other. Cleaned up these tests.