BUG: SparseSeries concat results in dense #12844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Bug
Reshaping
| if len(typs) == 1: | ||
| fill_values = set(c.fill_value for c in to_concat) | ||
| if len(fill_values) == 1: | ||
| sp_values = [c.sp_values for c in to_concat] |
There was a problem hiding this comment.
can you make a comment here that explains what is happening (that you need 1 typ and 1 fill value to get back a Sparse result), otherwise its dense)
sinhrks
force-pushed
the
sparse_concat
branch
3 times, most recently
from
c42b399
to
5a35961
Compare
|
@jreback Added |
| @@ -0,0 +1,329 @@ | |||
| """ | |||
There was a problem hiding this comment.
why don't we put this in pandas/types/concat.py
sinhrks
force-pushed
the
sparse_concat
branch
2 times, most recently
from
0262511
to
5f94366
Compare
|
lgtm. any tests to move as well? (from core/common.py)? |
|
actually going to merge this. other things going to depend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff