Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: correctly provide __name__ for cum functions #12372

Closed
wants to merge 2 commits into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Feb 17, 2016

closes #12021

(py3.5)[Tue Apr 05 08:16:18 ~/miniconda/envs/py3.5/pandas]$ ipython
Python 3.5.1 |Continuum Analytics, Inc.| (default, Dec  7 2015, 11:24:55) 

In [1]: pd.Series.sum.__qualname__
Out[1]: 'Series.sum'

In [2]: pd.Series.cumsum.__qualname__
Out[2]: 'Series.cumsum'

In [3]: pd.Series.cumsum.__module__
Out[3]: 'pandas.core.series'

In [4]: pd.Series.cumsum.__name__
Out[4]: 'cumsum'

@jreback jreback added this to the 0.18.0 milestone Feb 17, 2016
@jreback
Copy link
Contributor Author

jreback commented Feb 17, 2016

cc @mrocklin

@jreback
Copy link
Contributor Author

jreback commented Mar 14, 2016

0.18.0

In [1]: Series.sum.__qualname__
Out[1]: '_make_stat_function.<locals>.stat_func'

this PR

In [1]: Series.sum
Out[1]: <function pandas.core.series.Series.sum>

In [2]: Series.sum.__qualname__
Out[2]: 'Series.sum'

In [3]: Series.cumsum.__qualname__
Out[3]: 'Series.cumsum'

cc @mrocklin
this doesn't solve the cloudpickle issue, but I think makes progress

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Mar 14, 2016
@jreback jreback force-pushed the closure branch 2 times, most recently from d51f849 to 4340a8f Compare March 14, 2016 20:59
@jreback
Copy link
Contributor Author

jreback commented Mar 20, 2016

cc @mrocklin did you have a chance to try this?

@jreback jreback force-pushed the closure branch 3 times, most recently from f33c421 to 99eeb67 Compare March 20, 2016 18:53
@jreback jreback force-pushed the closure branch 4 times, most recently from ef448ca to abd6aec Compare April 5, 2016 12:51
CLN: move _fill_zeros -> missing.py
CLN: rename missing.* methods w/o leading _
@mrocklin
Copy link
Contributor

mrocklin commented Apr 5, 2016

Ah, sorry for letting this slip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serializing Pandas Functions
2 participants